Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipes-targets): add Kinesis #30656

Merged
merged 8 commits into from
Oct 3, 2024
Merged

feat(pipes-targets): add Kinesis #30656

merged 8 commits into from
Oct 3, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Jun 25, 2024 •
edited
Loading

Add Kinesis data stream as a Pipes target.

It's nontrivial to get the data from the Kinesis data stream, but here are screenshots
showing data made it through during the integration test.

Screenshot 2024-06-24 at 7 24 10 PM Screenshot 2024-06-24 at 7 26 35 PM

@github-actions github-actions bot added the p2 label Jun 25, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 25, 2024 02:01
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jun 25, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 25, 2024
nmussy
nmussy suggested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, should be good to go otherwise

packages/@aws-cdk/aws-pipes-targets-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 25, 2024
@msambol
Copy link
Contributor Author

msambol commented Jun 25, 2024

@nmussy Updated as well. Thanks again!

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

This was referenced Jul 1, 2024
Closed
Closed
@pahud pahud added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@msambol msambol force-pushed the pipe-targets-kinesis branch 2 times, most recently from 48ddddf to 352bcf8 Compare September 29, 2024 17:28
@Leo10Gama Leo10Gama self-assigned this Oct 1, 2024
Leo10Gama
Leo10Gama previously requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a few minor changes/suggestions from my end.

packages/@aws-cdk/aws-pipes-targets-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed Leo10Gama’s stale review October 3, 2024 17:25

Pull request has been modified.

@msambol
Copy link
Contributor Author

msambol commented Oct 3, 2024

@Leo10Gama – fixed. Thanks for the review!

Leo10Gama
Leo10Gama approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@Leo10Gama
Copy link
Member

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 3, 2024

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 3, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d4ec5cb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d0c99d8 into aws:main Oct 3, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 3, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nmussy nmussy nmussy requested changes

@Leo10Gama Leo10Gama Leo10Gama approved these changes

Assignees

@Leo10Gama Leo10Gama

Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msambol @aws-cdk-automation @Leo10Gama @nmussy @pahud